fix(http): options not parsed accurately#2914
Merged
icecrasher321 merged 3 commits intostagingfrom Jan 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixed two HTTP request handling issues in
These changes ensure compatibility with Node.js's DNS resolution behavior and prevent potential decompression issues when making HTTP requests through the security-pinned fetch mechanism. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as HTTP Tool
participant Executor as executeToolRequest
participant Validator as validateUrlWithDNS
participant Fetch as secureFetchWithPinnedIP
participant DNS as dns.lookup
participant HTTP as Node.js http/https
Client->>Executor: Execute HTTP request with headers
Note over Executor: Headers include Accept-Encoding: gzip, deflate, br
Executor->>Validator: validateUrlWithDNS(url)
Validator->>DNS: Resolve hostname to IP
DNS-->>Validator: Resolved IP address
Validator-->>Executor: { isValid: true, resolvedIP }
Executor->>Fetch: secureFetchWithPinnedIP(url, resolvedIP, options)
Note over Fetch: Remove accept-encoding header<br/>(Node.js doesn't auto-decompress)
Fetch->>Fetch: Create custom lookup function
Note over Fetch: Handle options.all:<br/>- true: return [{ address, family }]<br/>- false: return (address, family)
Fetch->>HTTP: http.request() with custom agent
HTTP->>Fetch: Custom lookup called
Fetch-->>HTTP: Return pinned IP (not DNS)
HTTP-->>Fetch: Response (uncompressed)
Fetch-->>Executor: SecureFetchResponse
Executor-->>Client: Tool response
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist